Add entry to subevent log when filtering out recipient #35509
Merged
+46
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: corehq/messaging/scheduling/scheduling_partitioned/models.py
Did you find this useful? React with a 👍 or 👎 |
MartinRiese
requested review from
a team,
minhaminha and
Jtang-1
and removed request for
a team
Jtang-1
approved these changes
Dec 11, 2024
Jtang-1
approved these changes
Dec 11, 2024
Jtang-1
approved these changes
Dec 12, 2024
Jtang-1
approved these changes
Dec 12, 2024
Jtang-1
reviewed
Dec 12, 2024
| @@ -344,7 +344,7 @@ def log_filtered_recipient(filtered_recipient, reason): | |||
| filtered_recipient, | |||
| content, | |||
| ) | |||
| sub_event.error(MessagingEvent.FILTER_MISMATCH, reason) | |||
| sub_event.error(MessagingEvent.FILTER_MISMATCH, reason, MessagingEvent.STATUS_COMPLETED) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
When alert recipients are filtered out it is hard to figure out why. Currently we have bug in production that we cannot reproduce otherwise. This will help determine what exactly is happening.
Technical Summary
https://dimagi.atlassian.net/browse/SUPPORT-22779
Feature Flag
None
Safety Assurance
Automated tests and tested on staging.
Safety story
Automated test coverage
Yes.
QA Plan
Rollback instructions
Labels & Review